I've stayed at lots of places in & around York for many years. Depending on your objectives and tolerance level (and that of your traveling companions), there is a range of choices. My thoughts...
Super 8 in York - deteriorated in recent years, relatively less expensive, some sketchy folks but parking lot is well-lit. I've never had a problem there.
Days Inn (former Billy Budd) - One of the staff (Margaret) goes out of her way to accommodate TCAers, and there is a special rate. Lots of remodeling in the past couple of years. Easy in/out. Call Margaret and see what she can do for you.
Wyndham - Very nice, very close, bandit meets on site. Pricey, and fills up quickly.
You can also stay in Carlisle (if it's not the car meet week). Much less money than York. About a 40-minute scenic drive (on PA 74) to the fairgrounds, and you enter York from the northwest, so it's easy to get to the meet. Great beer and decent food at Market Cross Pub makes Carlisle a nice stay.
Lancaster - The modest chains like Super 8 are much cheaper in Lancaster, and it's only about a half-hour drive to York, albeit in the traffic on US 30. You can save a bunch of money, reservations are easier to get, and it's a short drive to all of the train attractions in Strasburg.
IMO, Harrisburg is the worst option - relatively high prices, no nearby attractions, and the drive to/from the fairgrounds is brutal.
