Why not stay at the 'Red Caboose'. It would mean a bit of a journey to York itself, but it's very handy the museum, Strasburg Railroad and other attractions. Plus, what could be better than staying in a real caboose? I write this assuming that the Red Caboose motel is still there. It is almost 20 years since I last stayed there.
Its still there, I slept in a caboose there a month ago, although I dont know if I'd want to spend a long weekend in one. It was fine for a night, but I think for 4 days, I'd want an actual hotel room.
Half way between strasburg and York is Lancaster and there's all sorts of places to stay there. Shouldnt be a problem to find a convenient place to stay.