Here's the stats for Model Railroader magazine in 2010:
http://www.echo-media.com/mediaDetail.php?ID=17047
Average monthly sales - 146,000 copies.
Average income - $75K
Average age - 58
Way back when someone on here started a topic of average age of the folks who post here and I think it was 55. I can see that 58 is probably correct now.
The above averages are for 1 magazine only. I'm almost sure all magazines have to release similar data on a yearly basis so maybe if someone had the data for all RR magazines they could come up with a number. Then again, not everybody subscribes to a magazine, so any number is a SWAG.
Of the 600 people in my old command, I knew of only 6 who were model railroaders, 1%. I would guess that probably no more than 1% of the entire US population are model railroaders, which would be approx 3,000,000.