I'm starting to weather my freight cars. Since I'm modelling a 1950's Era steel mill, I prefer that those cars and locomotives have some degree of rust and dirt on them. They make the layout more realistic.
Here's a few examples. If I had some truly collectible cars and locomotives, then I would leave them alone. It's all a matter of preference.