My favorite is the one that I am visiting at the given moment. All RR museums have something to offer, whether it be a massive collection such as IRM or a single car or locomotive on display. There is always a story to tell. If you go in with the attitude that you want to discover the story, you will be much more satisfied than if you came to see a bunch of large industrial equipment. Even the rusting hulks have a story to tell.
Tom