My favorites are:
National Railway Museum York, U.K.
Railroad Museum of Pennsylvania
California State Railroad Museum
B&O Railroad Museum
Nevada State Railroad Museum
I have visited many others and the names escape me, but I know that I enjoyed them all!
Eric Hofberg
TCA, LCCA