In "Norfolk & Western Railway: Williamson Terminal—1953" Vern French goes into pretty good detail about tender assignments for each class of locomotive including the Class A. One thing that should be understood is that N&W did not use an "A" designation for their Class A tenders. The tenders of the Class A engines were designated "B", "H", "C" and "I" and each were different.
Class "I" tenders
Engines 1235-1242 are all noted as receiving Class "I" tenders, the tender that is shown in the 1238 builders photo. The "I" tenders were also assigned to all of the Y6b engines.
Class "C" tenders
In the late forties 1210-1234 for the most part were assigned class "C" tenders. I say "for the most part" because there are some tenders documented as being swapped in the 1950s. The class "C" tender is the tender you see on the 1218 today. The class "C" tender is also correct for the Postwar 1211.
In an article in Mainline Modeler, July 1984, Tom Dressler and Ed King wrote about the Class A engines and their details and differences. In reporting about the last 8 A engines built, Dressler and King write:
"The first three, #1235, #1236 and 1237, were to be identical to the modified wartime A's with two exceptions—the engines were equipped with fluted eccentric rods with roller bearing back ends and a new design of Commonwealth 6-wheel roller bearing tender trucks. Nos. 1238-1242 utilized these modifications and more. These engines were equipped with Timken roller bearing side and main rods. ..."
I added the emphasis in the above quote. To be clear, 1235, 1236 and 1237 did NOT get roller bearing side and main rods but did get the "I" tender and newly designed trucks. The Dressler/King article shows a photo of the trucks across a full page so clearly, but of course I can't post that photo of them.
1235-1242 Tender Note the more rounded curve in the coal bunker.
1210-1234 Tender Note the more abrupt curve in the bunker.
1235-1242 Trucks
1210-1234 Trucks
Note difference in the notch at the front of the tenders:
1235-1242 the notch is simply rounded.
1210-1234 the notch has a backwards S curved sheet of metal.
These are the most obvious differences in the "I" and "C" tenders. This doesn't get into the different rivet patterns on the tenders. I would understand Lionel not using the correct tender for the 1238 if they did not already have the tooling. But Lionel DOES have the tooling for the 1238 "I" tender and they DO have the tooling for the correct trucks.