In my humble opinion, combined with other local train attractions, a York vacation would be worthy of 7 to 10 days of my time. Not to mentions some very good Pennsylvania Dutchy eating!
The first two visits I concentrated on the Orange Hall. This year I visited EVERY SINGLE ONE. Talk about sugar overload - but it was GREAT. You have got to pace yourself.
When my wife and I move to that area (daughter and brother live there already) we will be happy to take in a verified OGR train buddy or 3.